Include old resolv.conf contents without nameservers #10731
+33
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonrw
added
the
semver: patch
simonrw
force-pushed
the
dns/keep-resolvconf-options
branch
from
27034f5
to
d11547e
Compare
dfangl
approved these changes
May 24, 2024
| new_contents = infile.read() | ||
|
|
||
| lines = new_contents.splitlines() | ||
| assert "nameserver 127.0.0.1" in lines |
There was a problem hiding this comment.
Could you add an assertion that nameserver 127.0.0.11 is not in lines as well? To make sure the filtering works as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
A user mentioned that their DNS lookups within their Kubernetes cluster did not work with "simple" names, e.g. looking up a service by its name only - not specifying
.cluster.localor.<namespace>.svc.cluster.localetc.Changes
/etc/resolv.confwe only update thenameserversfields, leaving thesearchandndots(and others) at their original values