Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPIKE: CFn: minor cleanups #10762

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

SPIKE: CFn: minor cleanups #10762

wants to merge 8 commits into from

Conversation

simonrw
Copy link
Contributor

@simonrw simonrw commented May 3, 2024

Motivation

Yes this is a grab bag of lots of changes, which is very bad PR etiquette...

This is mostly a way to run the CI on these changes. I may split the changes up in the future.

Changes

  • Remove unused code
  • Resolve FIXME
  • Add get_instance method to stackset
  • Fix metadata and typing
  • Create initial v2 engine
  • Fetch deployable resource ids
  • Validate test_update_stack_actual_update
  • Force resource fetching

@simonrw simonrw added the semver: patch Non-breaking changes which can be included in patch releases label May 3, 2024
@simonrw simonrw self-assigned this May 3, 2024
Copy link

github-actions bot commented May 3, 2024

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 38m 43s ⏱️ +39s
2 926 tests ±0  2 627 ✅  - 7  292 💤 ±0  7 ❌ +7 
2 928 runs  ±0  2 627 ✅  - 7  294 💤 ±0  7 ❌ +7 

For more details on these failures, see this check.

Results for commit 323e4ea. ± Comparison against base commit 3c06fd4b.

@simonrw simonrw changed the title CFn: minor cleanups SPIKE: CFn: minor cleanups May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant