Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quote templating on formats to be compatible with Podman #10767

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Quote templating on formats to be compatible with Podman #10767

wants to merge 1 commit into from

Conversation

desiderantes
Copy link

Motivation

Podman 4.x fails on the inspect stage of localstack stack because the templating passed is not quoted. I know Docker allows it unquoted too, but it also accepts it quoted, hence this PR

Changes

Add single quotes around all templating passed in docker_cmd_client.py

localstack-bot
localstack-bot reviewed May 3, 2024
View reviewed changes
Copy link
Collaborator

@localstack-bot localstack-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to LocalStack! Thanks for raising your first Pull Request and landing in your contributions. Our team will reach out with any reviews or feedbacks that we have shortly. We recommend joining our Slack Community and share your PR on the #community channel to share your contributions with us. Please make sure you are following our contributing guidelines and our Code of Conduct.

@localstack-bot
Copy link
Collaborator

localstack-bot commented May 3, 2024 •
edited

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@desiderantes
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

localstack-bot added a commit that referenced this pull request May 3, 2024
@localstack-bot
@desiderantes has signed the CLA in #10767
5d31a12
@alexrashed
Copy link
Member

Hi @desiderantes!
I just stumbled over this PR :) Please be aware that reviewers are not informed for as long the PR is not marked as "Ready for Review". 😉
And to maybe speedup a review: It would be great to have these changes covered in our tests.

@alexrashed alexrashed added the semver: patch Non-breaking changes which can be included in patch releases label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@localstack-bot localstack-bot localstack-bot left review comments

@dfangl dfangl Awaiting requested review from dfangl dfangl will be requested when the pull request is marked ready for review dfangl is a code owner

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert will be requested when the pull request is marked ready for review dominikschubert is a code owner

Assignees
No one assigned
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@desiderantes @localstack-bot @alexrashed