[SFN] Support for Glue Optimised Service Integration #10802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MEPalma
added
the
semver: patch
joe4dev
approved these changes
May 14, 2024
There was a problem hiding this comment.
LGTM. Nevertheless, I would prefer having a green test run before merging. Can we use companion branches to run the full test suite, in particular the new tests for this code in localstack-ext?
Re-basing both PRs (it seems the localstack community PR might be outdated causing issues in the ext pipeline) and pushing them simultaneously should work.
Just commented some (tiny) nits.
...pfunctions/asl/component/state/state_execution/state_task/service/state_task_service_glue.py
Outdated
Show resolved
Hide resolved
...pfunctions/asl/component/state/state_execution/state_task/service/state_task_service_glue.py
Outdated
Show resolved
Hide resolved
...pfunctions/asl/component/state/state_execution/state_task/service/state_task_service_glue.py
Show resolved
Hide resolved
MEPalma
force-pushed
the
MEP-sfn-glue_optim_inte
branch
from
925e41c
to
29e9f4d
Compare
MEPalma
requested review from
alexrashed,
dfangl,
pinzon,
simonrw and
Morijarti
as code owners
MEPalma
force-pushed
the
MEP-sfn-glue_optim_inte
branch
from
877d977
to
0694d46
Compare
joe4dev
reviewed
May 17, 2024
|
|
||
|
|
||
| @pytest.fixture | ||
| def sfn_events_to_sqs_queue(events_to_sqs_queue): |
There was a problem hiding this comment.
cc @maxhoheiser We now have SFN fixtures in localstack, which can be useful for integrations in EventBridge and EventBridge Pipes 🥳
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently the SFN v2 provider does not support Glue optimised integrations. This PR adds base support for Glue optimised integration.
Closes: #10073 (I'm author of this issue)
Changes
Testing
Glue is a Pro feature, tests are added in the PR in tandem with this one.