Pin importlib-metadata dependency to maintain CLI compatibility for python 3.7 #6969
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
importlib-metadata
recently had their 5.0 major version update, where they removed some "compatibility shims" (https://importlib-metadata.readthedocs.io/en/latest/history.html). I think it is, more concretely, python/importlib_metadata#284 which lead to the incompatibility.This lead to stevedore returning an error, since it tries to access the entrypoints like a dict, and therefore in python 3.7 (3.8 and later use importlib.metadata directly) the CLI to start LS did not work anymore.
Since stevedore abandoned python3.7 with its latest version 4.0.0, the chances of a fix are slim (even though the dict-like access might be removed at some point), so for now a dependency pin has to suffice.
Solution
Pin the dependency of importlib-metadata to <5.0 for now. Since this dependency is only used in python3.7 or lower, the pin is only applicable for those versions.