Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin importlib-metadata dependency to maintain CLI compatibility for python 3.7 #6969

Merged
merged 1 commit into from Oct 4, 2022

Conversation

dfangl
Copy link
Member

@dfangl dfangl commented Oct 3, 2022

Problem

importlib-metadata recently had their 5.0 major version update, where they removed some "compatibility shims" (https://importlib-metadata.readthedocs.io/en/latest/history.html). I think it is, more concretely, python/importlib_metadata#284 which lead to the incompatibility.
This lead to stevedore returning an error, since it tries to access the entrypoints like a dict, and therefore in python 3.7 (3.8 and later use importlib.metadata directly) the CLI to start LS did not work anymore.
Since stevedore abandoned python3.7 with its latest version 4.0.0, the chances of a fix are slim (even though the dict-like access might be removed at some point), so for now a dependency pin has to suffice.

Solution

Pin the dependency of importlib-metadata to <5.0 for now. Since this dependency is only used in python3.7 or lower, the pin is only applicable for those versions.

@dfangl dfangl requested a review from thrau October 3, 2022 14:44
@dfangl dfangl temporarily deployed to localstack-ext-tests October 3, 2022 14:44 Inactive
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.008%) to 79.069% when pulling e79f5dd on fix-python37-cli into 4b8318e on master.

@github-actions
Copy link

github-actions bot commented Oct 3, 2022

LocalStack integration with Pro

       3 files  ±0         3 suites  ±0   1h 13m 37s ⏱️ - 1m 49s
1 339 tests ±0  1 217 ✔️ ±0  122 💤 ±0  0 ±0 
1 853 runs  ±0  1 585 ✔️ ±0  268 💤 ±0  0 ±0 

Results for commit e79f5dd. ± Comparison against base commit 4b8318e.

Copy link
Member

@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent! love the version constraint

@thrau thrau merged commit 52b1831 into master Oct 4, 2022
@thrau thrau deleted the fix-python37-cli branch October 4, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants