Modern UI - Failures line chart does not display current number of failures #2471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2469
I propose adding a property
total_fail_per_secto/stats/requests, which tracks the total number of failures from the aggregated row. We will then use this as the proper value forcurrentFailPerSecin the charts.The old UI used to use
report.stats[report.stats.length-1]in the frontend. If you are against making changes to the python code we could do the same, however I am of the opinion that it is logical since we already returncurrent_rpsand this helps keep the FE "dumb" (it shouldn't really need to know that total stats are always last in the array)