Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to modify custom parameters from the modern UI #2491

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

andrewbaldwin44
Copy link
Collaborator

Fixes #2489

Tested that all types of inputs can be modified:
image

Tested the correct data is submitted in form:
image

@cyberw cyberw merged commit 889b917 into locustio:master Nov 27, 2023
15 checks passed
@cyberw
Copy link
Collaborator

cyberw commented Nov 27, 2023

Nice! Do you think you'll have time to have a look at automated UI-tests? I was thinking it might be nice to have in place before we switch to modern UI as default... Once the first tests are in place I dont mind doing some work to add additional tests myself, but I'd probably make a mess if I implemented it from scratch :)

@andrewbaldwin44
Copy link
Collaborator Author

Tests are already about 70% done, I'm working on it it's just taking some time :) You're more than welcome to help out if you would like but I should be able to get it done over the next couple days or so

@cyberw
Copy link
Collaborator

cyberw commented Nov 27, 2023

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to modify custom parameters from UI using modern UI
2 participants