Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Web UI About box #2510

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Update Web UI About box #2510

merged 2 commits into from
Dec 8, 2023

Conversation

cyberw
Copy link
Collaborator

@cyberw cyberw commented Dec 8, 2023

No description provided.

@cyberw
Copy link
Collaborator Author

cyberw commented Dec 8, 2023

LGTY @andrewbaldwin44 ? (as in: did I make any horrible mistakes? :)

the about box looks a little strange in dark mode still/again...

image

@andrewbaldwin44
Copy link
Collaborator

Looks super nice to me! 馃憤

@cyberw cyberw merged commit f39966a into master Dec 8, 2023
29 checks passed
@andrewbaldwin44
Copy link
Collaborator

Not enough border on dark mode or too dark?

@cyberw
Copy link
Collaborator Author

cyberw commented Dec 8, 2023

I think my screen is a little bad and crushes all the blacks :)

Maybe the background (in the about box) needs to be slightly lighter?

@cyberw
Copy link
Collaborator Author

cyberw commented Dec 8, 2023

Hehe, resetting my screen settings to default made it much more visible (although it is nice to cater to people with semi-broken screens too :)

@andrewbaldwin44
Copy link
Collaborator

Isn't that what light mode is for? 馃槅 but yeah I can look into it 馃憤

@cyberw
Copy link
Collaborator Author

cyberw commented Dec 8, 2023

Haha, yea I guess you're right. No need to put it at the top of your list or anything :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants