Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support IPv6 for zmq connection between master and worker #2521

Merged
merged 2 commits into from
Dec 25, 2023

Conversation

simonwu-sn
Copy link
Contributor

@simonwu-sn simonwu-sn commented Dec 23, 2023

This is a follow up for PR #2290.

The solution is based on http://api.zeromq.org/4-2:zmq-setsockopt.

Set the IPv6 option for the socket. A value of 1 means IPv6 is enabled on the socket, while 0 means the socket will use only IPv4. When IPv6 is enabled the socket will connect to, or accept connections from, both IPv4 and IPv6 hosts.

The test is done with kind for 3 env, ipv4 only, ipv6 only and dual stack. With help of https://abdelrhmanhamouda.github.io/locust-k8s-operator/

Test result:
ipv4-only before-patch(success) after-patch(success)
ipv6-only before-patch(fail, the worker can't connect with master) after-patch(success)
dualstack before-patch(success) after-patch(success)

@cyberw
Copy link
Collaborator

cyberw commented Dec 23, 2023

Seems to have the same issue as the previous PR. I’m all for supporting ipv6, but someone needs to figure out the GH/build issue.

@simonwu-sn
Copy link
Contributor Author

Collaborator

Do you mean the make test will hung?

@simonwu-sn
Copy link
Contributor Author

test fixed.

@cyberw cyberw changed the title Add IPv6 support for zmq connections Support IPv6 for connection between master and worker Dec 25, 2023
@cyberw cyberw changed the title Support IPv6 for connection between master and worker Support IPv6 for zmq connection between master and worker Dec 25, 2023
@cyberw cyberw merged commit c9950b5 into locustio:master Dec 25, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants