[Modern UI] Refactor and Add Tests for Entrypoints #2613
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal
We shouldn't change code to fit the tests, however we should write code in such a way that it is easily testable. After some thought, I concluded that the 'App' file wasn't really rendering the App, but rather a piece of the App. Additionally the 'index' file was doing a lot more than is should be doing, and in this way some important app logic could not be tested.
This PR:
I also ensured in the backend that we have test coverage for: