Do not call blocking content property and lazily load response
#2643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neiser
changed the title
content property and lazily load response
neiser
force-pushed
the
fix-stream-support
branch
4 times, most recently
from
ebe49a0
to
a0c7694
Compare
|
@cyberw I'm finally done with this PR. Please review! |
|
maybe set self._cached_content to None if there is an exception? And update the title of the PR? |
neiser
commented
Mar 20, 2024
…st access This reverts commit 7ce89a0 and improves it
neiser
force-pushed
the
fix-stream-support
branch
from
a0c7694
to
4ffa84a
Compare
|
I went ahead and made a new release :) 2.24.1 should be out shortly. Also, all PR merges are pushed to pypi as prereleases (install the latest one by using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 7ce89a0 and improves it for cases when
stream=Trueandcatch_response=True. Together with #2642, this finally makes handling long-running streaming requests possible and reporting a failure while consuming the response.The problem is that calling
response.contenttriggers areadof the whole response eventually, rendering subsequent (streaming) reads pointless.