feat: add support for devcontainer up --workspace-env-file #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: eduardodbr <eduardodbr@hotmail.com>
eduardodbr
commented
Mar 27, 2024
89luca89
requested changes
Mar 28, 2024
|
Thanks a lot @eduardodbr for the PR! Just a couple of adjustments 😄 great work, thanks! |
Signed-off-by: eduardodbr <eduardodbr@hotmail.com>
Done the suggested changes, thanks. Also changed |
89luca89
approved these changes
Apr 2, 2024
|
Thanks a lot @eduardodbr LGTM, running the test suite, and if all is green will merge 👍 |
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #827
Each file from the list is parsed for key value pairs in the format
key=valueand merged with the remaining--workspace-envvariables.