feat(vclusterctl): Prevent distro/backingstore switch #1694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vcluster-docs canceled.
|
ThomasK33
force-pushed
the
thomaskosiewski/eng-3435-prevent-distrobackingstore-switch-also-in-vclusterctl
branch
from
507de68
to
caaa445
Compare
ThomasK33
force-pushed
the
thomaskosiewski/eng-3435-prevent-distrobackingstore-switch-also-in-vclusterctl
branch
from
caaa445
to
6c8872b
Compare
ThomasK33
force-pushed
the
thomaskosiewski/eng-3435-prevent-distrobackingstore-switch-also-in-vclusterctl
branch
from
6c8872b
to
6759581
Compare
FabianKramm
reviewed
Apr 16, 2024
| return err | ||
| } | ||
|
|
||
| if ok, err := setup.CheckUsingHelm(ctx, cmd.kubeClient, args[0], cmd.Namespace, cmd.Distro, cfg.BackingStoreType()); err != nil { |
There was a problem hiding this comment.
Since people can configure the distro via values now as well, I think this can be problematic here. I would leave out the CLI check for now
FabianKramm
reviewed
Apr 16, 2024
| // TODO(johannesfrey): We would also need to validate here if the user is about to perform changes which would lead to distro/store changes | ||
| // (johannesfrey): We would also need to validate here if the user is about to perform changes which would lead to distro/store changes | ||
| if isCurrentlyDeployed { | ||
| if ok, err := setup.CheckUsingHelm(ctx, cmd.kubeClient, args[0], cmd.Namespace, cfg.Distro(), cfg.BackingStoreType()); err != nil { |
There was a problem hiding this comment.
Same as above, maybe we should wait with CLI check for now
ThomasK33
deleted the
thomaskosiewski/eng-3435-prevent-distrobackingstore-switch-also-in-vclusterctl
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix
/kind enhancement
/kind feature
/kind documentation
/kind test
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves #
Please provide a short message that should be published in the vcluster release notes
Fixed an issue where vcluster ...
What else do we need to know?