Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for chardet and incompatible sphinx 4.1.0 or newer #3800 #3801

Merged
merged 5 commits into from Jul 15, 2021

Conversation

sydp
Copy link
Contributor

@sydp sydp commented Jul 15, 2021

One line description of pull request

Update version specifier for sphinx to ignore versions >= 4.1.0

Description:

This is a fix to allow tox docs to successfully complete.

Related issue (if applicable): fixes #3800

Notes:

All contributions to Plaso undergo code
review
. This makes sure
that the code has appropriate test coverage and conforms to the Plaso style
guide
.

One of the maintainers will examine your code, and may request changes. Check off the items below in
order, and then a maintainer will review your code.

Checklist:

  • Automated checks (Travis, Codecov, Codefactor )pass
  • No new new dependencies are required or l2tdevtools has been updated
  • Reviewer assigned

@joachimmetz
Copy link
Member

@sydp seeing chardet is not a direct dependency I've made some additional changes. I'll create a separate change to reflect this in dependencies.ini as well and I can explain more how dependencies.ini, requirements.txt and plaso/dependencies.py relate if you want.

@sydp
Copy link
Contributor Author

sydp commented Jul 15, 2021

@sydp seeing chardet is not a direct dependency I've made some additional changes. I'll create a separate change to reflect this in dependencies.ini as well and I can explain more how dependencies.ini, requirements.txt and plaso/dependencies.py relate if you want.

Sounds good. Thanks for helping to resolve this.

@joachimmetz joachimmetz changed the title Update version specifier for sphinx to ignore versions >= 4.1.0 Changes for chardet and incompatible sphinx 4.1.0 or newer #3800 Jul 15, 2021
@joachimmetz joachimmetz merged commit e098bae into log2timeline:main Jul 15, 2021
@sydp sydp deleted the 3800_sphinx_fix branch July 17, 2021 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sphinx 4.1.x breaks tox docs test
2 participants