Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented SQLite parser plugin for Android's app_usage database #4881

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

rick-slin
Copy link
Contributor

@rick-slin rick-slin commented May 1, 2024

One line description of pull request

Implemented SQLite parser plugin for Android's app_usage database.

Description:

Notes:

All contributions to Plaso undergo code review.
This makes sure that the code has appropriate test coverage and conforms to the
Plaso style guide.

One of the maintainers will examine your code, and may request changes. Check off the items below in
order, and then a maintainer will review your code.

Checklist:

  • Automated checks (GitHub Actions, AppVeyor) pass
  • No new new dependencies are required or l2tdevtools has been updated
  • Reviewer assigned

@rick-slin rick-slin closed this May 1, 2024
@rick-slin rick-slin reopened this May 1, 2024
@joachimmetz joachimmetz self-requested a review May 2, 2024 04:13
@joachimmetz joachimmetz self-assigned this May 2, 2024
@joachimmetz
Copy link
Member

Thanks for the PR, I'll take a look as time permits.

@joachimmetz
Copy link
Member

rebased with upstream for failing CI tests

@joachimmetz
Copy link
Member

@rick-slin PTAL, CI tests are failing with

======================================================================
FAIL: testParsersAndPresets (data.presets.PresetsDataTest)
Tests that all parsers/plugins in presets.yaml are valid.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/__w/plaso/plaso/tests/data/presets.py", line 32, in testParsersAndPresets
    self.assertFalse(invalid_parser_elements, msg=error_message)
AssertionError: {'sqlite/android_app_usage'} is not false : Invalid parser/plugin name(s) in preset: android

----------------------------------------------------------------------

Copy link

codecov bot commented May 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.11%. Comparing base (32ae7ba) to head (ecd86bc).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4881      +/-   ##
==========================================
+ Coverage   85.10%   85.11%   +0.01%     
==========================================
  Files         428      429       +1     
  Lines       38836    38861      +25     
==========================================
+ Hits        33051    33077      +26     
+ Misses       5785     5784       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants