Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dep): temporary fix for fs-extra issue (to be reverted when fs-extra patches it) #116

Merged
merged 1 commit into from Apr 15, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 7 additions & 1 deletion lib/RollingFileWriteStream.js
@@ -1,5 +1,11 @@
const debug = require("debug")("streamroller:RollingFileWriteStream");
const fs = require("fs-extra");

const realFs = require('fs');
const current = realFs.realpath.native;
if (!realFs.realpath.native) realFs.realpath.native = realFs.realpath;
const fs = require('fs-extra');
realFs.realpath.native = current;

const path = require("path");
const newNow = require("./now");
const format = require("date-format");
Expand Down
8 changes: 7 additions & 1 deletion lib/moveAndMaybeCompressFile.js
@@ -1,5 +1,11 @@
const debug = require('debug')('streamroller:moveAndMaybeCompressFile');
const fs = require('fs-extra');

const realFs = require('fs');
const current = realFs.realpath.native;
if (!realFs.realpath.native) realFs.realpath.native = realFs.realpath;
let fs = require('fs-extra');
realFs.realpath.native = current;

const zlib = require('zlib');

const _parseOption = function(rawOptions){
Expand Down
42 changes: 42 additions & 0 deletions test/fs-extra-test.js
@@ -0,0 +1,42 @@
const should = require("should");
const path = require("path");

describe("simulate fs monkey-patch", function() {
const fs = require("fs");
const realpathNativeBackup = fs.realpath.native;

beforeEach(function() {
// simulate fs monkey-patch
delete fs.realpath.native;
});

afterEach(function() {
// reset require.cache
delete require.cache[require.resolve("../lib/RollingFileWriteStream")];
delete require.cache[require.resolve("../lib/moveAndMaybeCompressFile")];
const fsePath = path.dirname(require.resolve("fs-extra"));
for (const entry in require.cache) {
if (entry.startsWith(fsePath)) {
delete require.cache[entry]
}
}
// reinstate fs.realpath.native
fs.realpath.native = realpathNativeBackup;
});

it("RollingFileWriteStream should not throw error", function() {
console.log(Object.keys(require.cache).length);
should.doesNotThrow(function() {
require("../lib/RollingFileWriteStream");
});
console.log(Object.keys(require.cache).length);
});

it("moveAndMaybeCompressFile should not throw error", function() {
console.log(Object.keys(require.cache).length);
should.doesNotThrow(function() {
require("../lib/moveAndMaybeCompressFile");
});
console.log(Object.keys(require.cache).length);
});
});