Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mark slot prop field value as any closes #3969 #3973

Merged
merged 1 commit into from Oct 23, 2022

Conversation

logaretm
Copy link
Owner

@logaretm logaretm commented Oct 23, 2022

What

Since there is no official generic component props support yet, we should mark the field slot prop value to be any to avoid errors with v-model prop bindings.

closes #3969

@logaretm logaretm self-assigned this Oct 23, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #3973 (b55dc7f) into main (8ccfd2b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3973   +/-   ##
=======================================
  Coverage   95.91%   95.91%           
=======================================
  Files          68       68           
  Lines        2009     2009           
  Branches      517      517           
=======================================
  Hits         1927     1927           
  Misses         82       82           
Impacted Files Coverage Δ
packages/vee-validate/src/Field.ts 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@logaretm logaretm merged commit 70ddc5b into main Oct 23, 2022
@logaretm logaretm deleted the fix/3969-mark-field-slot-prop-any branch October 23, 2022 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[V4] v-slot's "value" is of type unknown
2 participants