Unify log-level helper methods behavior. #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitry-goncharuk
force-pushed
the
improvement/v1.5.0/log-level
branch
from
b29912d
to
d4ab9fc
Compare
dmitry-goncharuk
force-pushed
the
improvement/v1.5.0/log-level
branch
from
d4ab9fc
to
01c508d
Compare
fiyinadebayo
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logdna::Rubylogger overrides its parentLoggerclass behavior for helper methods such as#info?.It also defines a 5th level
TRACEthat seems to be the same asLoger::Severity::UNKNOWN.So I've decided to rewrite the overridden methods because it makes
Logdna::Rubylogger incompatible with, for example, Rails. For exampleActionController::LogSubscriberhttps://github.com/rails/rails/blob/v5.2.1/actionpack/lib/action_controller/log_subscriber.rb#L8 is only logging responses when severity is set to belowINFO. But theLogdna::Ruby#info?returns false even if the log level has been set toDEBUG.