No header bar when launching Logseq with native Wayland flags

[VarLad]

What happened?

Launching Logseq using flatpak run com.logseq.Logseq --socket=wayland --enable-features=UseOzonePlatform --ozone-platform=wayland on GNOME 41 Wayland

No visible window decoration.

Reproduce the Bug

1. Install Logseq from Flathub using flatpak install flathub com.logseq.Logseq
2. Launching it with flatpak run com.logseq.Logseq --socket=wayland --enable-features=UseOzonePlatform --ozone-platform=wayland for native Wayland
3. No window decorations can be seen

Expected Behavior

Proper window decorations when launching Logseq in native Wayland mode.

Screenshots

No response

Desktop Platform Information

Fedora 35 Workstation on Wayland
Logseq 0.6.6

Mobile Platform Information

No response

Additional Context

Window decorations for GNOME has been present in Electron from 17.x.y versions, while a stable Wayland support is available in 18.x.y versions.
The best way to fix this in my opinion is to update the Electron version used by Logseq to 18.x.y

[cnrpman]

@VarLad Thanks for report.
Upgrading electron requires thorough consideration as it could easily break the dependencies based on our previous records..

[VarLad]

@cnrpman Thanks for the reply and I do understand the problem here.

Wayland is what most Linux users are now shifting to, and I hope an upgrade will be made considering that only the recent versions of Electron support window decorations on GNOME and some other features on Wayland.

[glyh]

Old electron also causes problem like #4288

[VarLad]

For now, the current implementation has problems upstream. electron/electron#33161
I'd suggest that this issue be put on hold for now.
We can do something after it gets resolved and released upstream

[GrantMoyer]

I tested on electron 19.0.8. Passing --enable-features=WaylandWindowDecorations in addition to the other wayland arguments does make window decorations, but they're unusable due to electron/electron#34820.

Note that the other issue, electron/electron#33161, is ugly but doesn't otherwise impact usability.

[GrantMoyer]

Passing --enable-features=WaylandWindowDecorations in addition to the other wayland arguments does make window decorations, but they're unusable due to electron/electron#34820.

This issue should be fixed when electron/electron#34955 lands. Of course, it will require another electron dependency upgrade, though hopefully just a minor version.

[VarLad]

@GrantMoyer It landed and was backported to 19-x-y. Now to wait for a release

[kanru]

It looks like electron 19.0.12 should include the fixes, but my flatpak build still has the window decoration mangled.

Will try to build the Logseq nightly..

[cnrpman]

@kanru 80fb12b
https://github.com/logseq/logseq/blob/master/package.json#L94
We are using 19.0.10 currently

[kanru]

@cnrpman Yes, I know. I patched my wayland branch to 19.0.12, but I think I missed one place.

[kanru]

I can confirm that upgrading to electron 19.0.12 does fix the no window decorator issue.

However my IME does not work in wayland mode. I think we need more testing before making it the default (--ozone-platform-hint=auto)

[VarLad]

@kanru For the flatpak, how about doing --ozone-platform-hint=auto and removing "Wayland" socket by default
That way, those who wanna use the native Wayland version can just enable the Wayland socket from Flatseal

Also, the above issue is https://bugs.chromium.org/p/chromium/issues/detail?id=1022724 and I doubt it'll be solved soon

[kanru]

@VarLad using --ozone-platform-hint=auto without wayland socket currently will segment fault.

flatpak run com.logseq.Logseq --ozone-platform-hint=auto
LaunchProcess: failed to execvp:
xdg-settings
[3:0901/235320.219183:ERROR:wayland_connection.cc(209)] Failed to connect to Wayland display
[3:0901/235320.219198:ERROR:ozone_platform_wayland.cc(226)] Failed to initialize Wayland platform
[3:0901/235320.219204:ERROR:env.cc(226)] The platform failed to initialize.  Exiting.
/app/bin/run.sh: line 2:     3 Segmentation fault      (core dumped) zypak-wrapper.sh /app/logseq/Logseq "$@"

So for now I will not add the default flags to 0.8.3 flatpak build.

[queeup]

you forgot to put --socket=wayland argument.

flatpak run --socket=wayland com.logseq.Logseq --ozone-platform-hint=auto
With this command there is No header bar unfortunately.

Need to add --enable-features=WaylandWindowDecorations also.

Final command is:
flatpak run --socket=wayland com.logseq.Logseq --ozone-platform-hint=auto --enable-features=WaylandWindowDecorations

Now my eyes can rest while I am working on Wayland with Logseq

[kanru]

I intentionally left out --socket=wayland because I want it to use x11 by default. Proposed by #5010 (comment)

I'm glad the final command works for you.

Please open a ticket in https://github.com/flathub/com.logseq.Logseq/issues to discuss how to make this easier to use, for example ship two different desktop files?

[queeup]

Yes I will but there is a problem about --ozone-platform-hint=auto here. It's not trigger WaylandWindowDecorations on wayland detect. We need to declare manually.

I don't know how to solve that.

[cab404]

Final command is: flatpak run --socket=wayland com.logseq.Logseq --ozone-platform-hint=auto --enable-features=WaylandWindowDecorations

Now my eyes can rest while I am working on Wayland with Logseq

Wow that actually works for the latest sway! Even while logseq Electron still has old wayland bindings!
Amazing, thank you!
How dumb am I not enabling wayland socket in flatpak :D

Alas cursors are becoming bodged with scaling, but still better than before)