Upgrade electron to 19

[GrantMoyer]

Electron 15 has been unsupported for some time now. Unfortunately, electron 15 also has a critical bug, which causes it to crash immediately when trying to render natively under wayland (specifically wlroots based compositors). This change upgrades the electron dependency to version 19, which is supported, and has fixed the bug.

I compiled the desktop app with electron 19 and played around with it a little, and I did not experience any strange behavior.

[GrantMoyer]

Fixes #4288

[GrantMoyer]

I tested locally and this does not fix #5010

[andelf]

Thanks, I will check this after 0.7.7 is released.

[Vectorrent]

Fixes #6052

[DoodlesEpic]

Closes #5642

[DoodlesEpic]

I'd suggest @andelf @GrantMoyer to take the opportunity to make all minor updates possible with this update. On my local branch (https://github.com/DoodlesEpic/Logseq/tree/update-electron-19) without breaking the build (and at least to the extent of my testing any features) I've managed to do all minor updates available reducing substantially the number of outdated direct deps of Logseq.

There's a few other updates that would be interesting including a few ones that would require major updates and solve somewhat serious vulnerabilities including one with node-fetch: GHSA-r683-j2x4-v87g although I'm not sure how affected Logseq is by this one.

[Vectorrent]

It seems that block references are partially-broken, after the update. They still work, but the "linked references" section doesn't render properly, after you click on it.

If you click on the little (1) button to "open block references," the entire app crashes with the following message:

Error caught by UI!
TypeError: Cannot read properties of null (reading '$cljs$core$IFn$_invoke$arity$1$')

No, a re-index doesn't fix it.

[Vectorrent]

Another issue: If you re-index after updating to Electron 19, a new page will be created for every, single page property. Stuff like "alias" and "id" will begin to show up on the graph, as its own node:

[Vectorrent]

Another issue: from "journal view," if you click on a page link, do some modifications, then "go back" to the journal view, you will be taken to a journal entry far earlier than the one you left from. If you scroll up, to return to where you were, the page may either 1) scroll back to the proper entry, or 2) "jump" above the proper entry - forcing you to scroll down.

[cnrpman]

Another issue: If you re-index after updating to Electron 19, a new page will be created for every, single page property. Stuff like "alias" and "id" will begin to show up on the graph, as its own node:

May checkout the latest master? It's related to #6024 I guess

[Vectorrent]

May checkout the latest master? It's related to #6024 I guess

This looked promising, but no dice. The new config option doesn't seem to work for me.

 ;; Enable all your properties to have corresponding pages
 :property-pages/enabled? false

On the other hand, the block reference issue is fixed, so that's progress.

[GrantMoyer]

I'd suggest to take the opportunity to make all minor updates possible with this update.

I'd like to keep the scope of this PR restricted, especially given the changes which will apparently be needed.

It seems that block references are partially-broken, after the update...

Thanks for finding these issues. I'll look into them.

[GrantMoyer]

It seems that block references are partially-broken, after the update. They still work, but the "linked references" section doesn't render properly, after you click on it.

I couldn't reproduce this issue, but it looks like it's been fixed anyway.

Another issue: If you re-index after updating to Electron 19, a new page will be created for every, single page property. Stuff like "alias" and "id" will begin to show up on the graph, as its own node

This doesn't seem to be caused by the electron update. I can indeed reproduce this with this branch (a5d71c8). However, I have 0.7.6 (8e3b8f0) compiled against electron 19 installed on my system, and this issue is not present.

I just double checked, and I also see this issue at the point where this PR branched from master (5c29517).

[GrantMoyer]

a new page will be created for every, single page property. Stuff like "alias" and "id" will begin to show up on the graph, as its own node

This issue is gone for me with the latest merge from master.

[Vectorrent]

This issue is gone for me with the latest merge from master.

Really? I'm still seeing the same behavior as #6124. Anyway, probably not an issue with the Electron update.

[cnrpman]

We are going to upgrade in recent days. But thorough tests required beforehand.

[andelf]

LGTM

BTW, electron 20.0.0 was released 2 days ago.
Should we go for it? @logseq/core

[tiensonqin]

@andelf Why not? It seems that all the breaking changes for 20.0.0 are not related to us.
https://www.electronjs.org/blog/electron-20-0

[VarLad]

Since they now include this flag, can we have Wayland by default? electron/electron#35015
(on Wayland)

[andelf]

Will merge this now. (which will be included in the nightly release)
And use the newest electron 19 release.
Since electron 20 is just released, it's better to wait for a few minor fixes.

[yoyurec]

What about Electron 21? there is Chromium 106!