Chore(deps): Upgrade electron to 20

[sprocketc]

Electron 19 reached end of support. Upgrading would also (hopefully) help us resolve various font rendering issues on linux. Electron 22.0.0 was released a couple of weeks ago, but it might be too soon to upgrade to 22. Also, electron 21 introduced a breaking change related to V8 Memory Cage that might cause issues. so I decided to go with 20 for now.

• Upgrade to electron to 20.3.8
• Upgade better-sqlite3 to 8.0.1 to include this fix (no relevant breaking changes on 8.0.0)
• Set sandbox window option to false (renderers are sandboxed by default on electron 20+)
• Rename and upgrade electron-rebuild to @electron/rebuild 3.2.10 (name deprecation notice here)
• Upgrade nan to handle this issue
• Upgrade electron-forge to 6.0.4 (this is a good opportunity to move to a stable version)

Successfully built and tested on

• Linux
• Windows
• MacOS

Regarding electron 21+

Electron 21 enables V8 sandboxed pointers, following Chrome's decision to do the same in Chrome 103. This has some implications for native modules. This feature has performance and security benefits, but also places some new restrictions on native modules, e.g. use of ArrayBuffers that point to external ("off-heap") memory. Please see this blog post for more information. #34724

• Discussion about native module usage in Electron 21+ [Bug]: Electron 21 breaks node-api stability guarantees electron/electron#35801
• Related issues
  • Electron21.2.0 Calling native node crashes nodejs/node-addon-api#1227
  • Electron 21 breaks api compatability with some modules nodejs/abi-stable-node#441
• Related PR node-api: handle no support for external buffers nodejs/node#45181

See #7692 (comment)

[cnrpman]

Good!
For more time to collect feedback, can we hold this until 0.8.13 is cut?

[andelf]

Fails to build on my macOS. Even after rm all and starting over.

electron-rebuild fails to rebuild fsevents with an error message related to the nan package.

[cnrpman]

Check the rendering issue after upgrade:
#7233 (comment)

[Bad3r]

✅ Tested building and running on Arch Linux using the latest kernel 6.1.0 using NodeJS LTS 16 (gallium). Logseq builds with NodeJS LTS 18 (hydrogen) but crashes when re-indexing the graph

[3591228:1215/015431.290602:ERROR:node_bindings.cc(146)] Fatal error in V8: v8_ArrayBuffer_NewBackingStore When the V8 Sandbox is enabled, ArrayBuffer backing stores must be allocated inside the sandbox address space. Please use an appropriate ArrayBuffer::Allocator to allocate these buffers.
[3591344:1215/015432.786357:ERROR:broker_posix.cc(40)] Recvmsg error: Connection reset by peer (104)
Segmentation fault (core dumped)

[sprocketc]

@Bad3r Thanks a lot for testing this! I updated the description of the PR with information that might be related to your issue. Could you please also post the exact versions of NodeJS that you used?

[sprocketc]

electron-rebuild fails to rebuild fsevents with an error message related to the nan package.

@andelf Thanks! That should be handled now.

[Bad3r]

Could you please also post the exact versions of NodeJS that you used?

I used NodeJS LTS Hydrogen (18.12.1)

https://nodejs.dev/en/about/releases/

Btw logseq fails to build with NodeJS 19/electron 21 due to better-sqlite3

In the electron 21 pr you linked to, they mention using NodeJS 16.17.0
(WiseLibs/better-sqlite3#870)

[Bad3r]

Is there more testing needed before pushing v20?

[sprocketc]

Is there more testing needed before pushing v20?

Hey @Bad3r! We put this on hold until 0.8.13-14. Let's wait for the rest of the team to also take a look. You have done more than enough ❤️

[cnrpman]

I hope now it's a good chance to introduce the upgrade?

[tiensonqin]

Any blockers on this PR?

[sprocketc]

Any blockers on this PR?

We should be good to merge this.

[Bad3r]

LGTM 🚀 
I have been testing it on Linux for a while without any issues

[tiensonqin]

Awesome, merged! 🚢

[cnrpman]

If you met this in the main.log (log for Electron main thread) in dev environment:

[2023-03-16 16:32:00.562] [error] Error: The module '/Users/jun/git/logseq/static/node_modules/better-sqlite3/build/Release/better_sqlite3.node'
was compiled against a different Node.js version using
NODE_MODULE_VERSION 108. This version of Node.js requires
NODE_MODULE_VERSION 107. Please try re-compiling or re-installing
the module (for instance, using npm rebuild or npm install).: local

try the following command to rebuild better-sqlite3:

1. go to the better-sqlite3 folder in node_modules inside the static folder;
2. npx node-gyp rebuild --release --target=20.3.8 --dist-url=https://electronjs.org/headers