Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove node-fetch #5588

Closed
wants to merge 1 commit into from
Closed

chore: remove node-fetch #5588

wants to merge 1 commit into from

Conversation

gao-sun
Copy link
Member

@gao-sun gao-sun commented Mar 29, 2024

Summary

as it's no longer needed since Node 18

Testing

ci

Checklist

  • .changeset
  • unit tests
  • integration tests
  • necessary TSDoc comments

@gao-sun gao-sun requested a review from a team March 29, 2024 05:24
Copy link

COMPARE TO master

Total Size Diff 📉 -1.67 KB

Diff by File
Name Diff
packages/integration-tests/jest.setup.js 📉 -54 Bytes
packages/integration-tests/package.json 📉 -28 Bytes
packages/integration-tests/src/include.d/node-fetch.d.ts 📉 -87 Bytes
packages/integration-tests/src/tests/api/oidc/get-access-token.test.ts 📉 -32 Bytes
pnpm-lock.yaml 📉 -1.48 KB

@gao-sun
Copy link
Member Author

gao-sun commented Mar 29, 2024

in favor of #5584

@gao-sun gao-sun closed this Mar 29, 2024
@gao-sun gao-sun deleted the gao-remove-node-fetch branch March 29, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

1 participant