refactor(experience): add global loading status on page redirect #5774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
COMPARE TO
|
| Name | Diff |
|---|---|
| .changeset/friendly-chicken-pump.md | 📈 +401 Bytes |
| packages/experience/src/containers/SocialLinkAccount/use-social-link-related-user.ts | 📈 +109 Bytes |
| packages/experience/src/containers/VerificationCode/use-continue-flow-code-verification.ts | 📈 +146 Bytes |
| packages/experience/src/containers/VerificationCode/use-register-flow-code-verification.ts | 📈 +112 Bytes |
| packages/experience/src/containers/VerificationCode/use-sign-in-flow-code-verification.ts | 📈 +112 Bytes |
| packages/experience/src/hooks/use-global-redirect-to.ts | 📈 +745 Bytes |
| packages/experience/src/hooks/use-password-sign-in.ts | 📈 +103 Bytes |
| packages/experience/src/hooks/use-send-mfa-payload.ts | 📈 +103 Bytes |
| packages/experience/src/hooks/use-skip-mfa.ts | 📈 +103 Bytes |
| packages/experience/src/hooks/use-social-link-account.ts | 📈 +103 Bytes |
| packages/experience/src/hooks/use-social-register.ts | 📈 +103 Bytes |
| packages/experience/src/pages/Consent/index.tsx | 📈 +109 Bytes |
| packages/experience/src/pages/Continue/SetPassword/index.tsx | 📈 +128 Bytes |
| packages/experience/src/pages/Continue/SetUsername/use-set-username.ts | 📈 +109 Bytes |
| packages/experience/src/pages/RegisterPassword/index.tsx | 📈 +127 Bytes |
| packages/experience/src/pages/SocialSignInWebCallback/use-single-sign-on-listener.ts | 📈 +158 Bytes |
simeng-li
requested review from
a team,
wangsijie and
charIeszhao
and removed request for
a team
wangsijie
approved these changes
Apr 24, 2024
|
Hold this PR for a comprehensive testing. |
darcyYe
approved these changes
Apr 24, 2024
|
This PR is stale because it has been open 10 for days with no activity. Remove stale label or comment or this will be closed in 5 days. |
add global loading status on page redirect
simeng-li
force-pushed
the
simeng-log-8266-should-show-loading-state-when-redirection-is-happening
branch
from
9aef633
to
3f8c027
Compare
|
@gao-sun changeset included PTAL |
gao-sun
approved these changes
May 20, 2024
simeng-li
deleted the
simeng-log-8266-should-show-loading-state-when-redirection-is-happening
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a new
useGlobalRedirecthook to handle all the sign-in/sign-up success redirections. Show the global loading status on redirect.This will prevent user interaction from the sign-in page while the HTTP redirect request is still loading.
Testing
WIP
Checklist
.changeset