-
-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(toolkit): update mobileUriSchemeProtocolRegEx #5843
base: master
Are you sure you want to change the base?
Conversation
COMPARE TO
|
Name | Diff |
---|---|
packages/toolkit/core-kit/src/regex.ts | 📉 -12 Bytes |
packages/toolkit/core-kit/src/utils/url.test.ts | 📉 -15 Bytes |
9bb58f0
to
4e27dc1
Compare
Well, unfortunately our underlying oidc provider library requires the |
@charIeszhao Sadly to see that. I really can't understand the reason that URL scheme of the native app must be |
Well, I understand that in real life there are many apps that do not have a domain based scheme, however, it is clearly stated in the IETF standard that these schemes should not be used. Here's the documentation for your reference: https://datatracker.ietf.org/doc/html/draft-ietf-oauth-native-apps-06#section-7.1.1 |
@charIeszhao Another similar problem: I'm developing an app with Expo, which supports both React Native and React Web. But I can't configure the |
A possible way I can think of is to set the scheme during building process, maybe. So you can still use the same code base, but when building the app for different platforms, you can have different uri schemes. Or do you have like a env flag in your code, like There might still be other better practices |
Summary
There's no requirement that the mobile schema must be
xxx.my://
; a simplemyapp://
should be okay.Testing
Before:
After:
Checklist
.changeset