Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(console, phrases): update the supported webhook events #5856

Merged
merged 11 commits into from
May 15, 2024

Conversation

simeng-li
Copy link
Contributor

@simeng-li simeng-li commented May 13, 2024

Summary

Update console webhook form to support new DataHook events.

This PR includes the following updates:

  • Add new defined DataHook events to the console webhook pages
  • Replace the old webhook event with a new component to better support the schema-grouped webhook events selectors.
  • Align the event name with the actual event value in the webhook. Remove the i18n translation keys of the interaction events. Directly use the hook event value in the console.

Testing

CreateForm:
image

DetailsForm:
image

List:
image

LogFilters:
image

Checklist

  • .changeset
  • unit tests
  • integration tests
  • necessary TSDoc comments

Copy link

github-actions bot commented May 13, 2024

COMPARE TO master

Total Size Diff 📈 +7.17 KB

Diff by File
Name Diff
.changeset/curvy-boxes-hide.md 📈 +412 Bytes
packages/console/src/components/BasicWebhookForm/index.tsx 📈 +422 Bytes
packages/console/src/consts/env.ts 📈 +52 Bytes
packages/console/src/consts/webhooks.ts 📈 +1.15 KB
packages/console/src/ds-components/Checkbox/CategorizedCheckboxGroup/index.module.scss 📈 +255 Bytes
packages/console/src/ds-components/Checkbox/CategorizedCheckboxGroup/index.tsx 📈 +1.04 KB
packages/console/src/ds-components/Checkbox/CheckboxGroup/index.tsx 📈 +26 Bytes
packages/console/src/pages/AuditLogDetails/index.tsx 📈 +20 Bytes
packages/console/src/pages/WebhookDetails/WebhookLogs/index.tsx 📈 +177 Bytes
packages/console/src/pages/WebhookDetails/utils.ts 📈 +587 Bytes
packages/console/src/pages/Webhooks/index.tsx 📈 +421 Bytes
packages/integration-tests/src/tests/api/hook/hook.trigger.interaction.test.ts 📈 +145 Bytes
packages/integration-tests/src/tests/console/webhooks/helpers.ts 📈 +1 Bytes
packages/integration-tests/src/tests/console/webhooks/index.test.ts 📈 +2 Bytes
packages/phrases/src/locales/de/translation/admin-console/webhooks.ts 📈 +271 Bytes
packages/phrases/src/locales/en/translation/admin-console/webhooks.ts 📈 +115 Bytes
packages/phrases/src/locales/es/translation/admin-console/webhooks.ts 📈 +266 Bytes
packages/phrases/src/locales/fr/translation/admin-console/webhooks.ts 📈 +257 Bytes
packages/phrases/src/locales/it/translation/admin-console/webhooks.ts 📈 +280 Bytes
packages/phrases/src/locales/ja/translation/admin-console/webhooks.ts 📈 +226 Bytes
packages/phrases/src/locales/ko/translation/admin-console/webhooks.ts 📈 +271 Bytes
packages/phrases/src/locales/pl-pl/translation/admin-console/webhooks.ts 📈 +277 Bytes
packages/phrases/src/locales/pt-br/translation/admin-console/webhooks.ts 📈 +285 Bytes
packages/phrases/src/locales/pt-pt/translation/admin-console/webhooks.ts 📈 +285 Bytes
packages/phrases/src/locales/ru/translation/admin-console/webhooks.ts 📈 +243 Bytes
packages/phrases/src/locales/tr-tr/translation/admin-console/webhooks.ts 📈 +271 Bytes
packages/phrases/src/locales/zh-cn/translation/admin-console/webhooks.ts 📈 +289 Bytes
packages/phrases/src/locales/zh-hk/translation/admin-console/webhooks.ts 📈 +289 Bytes
packages/phrases/src/locales/zh-tw/translation/admin-console/webhooks.ts 📈 +289 Bytes
packages/schemas/src/foundations/jsonb-types/hooks.ts 📈 +7 Bytes

@simeng-li simeng-li changed the title Simeng log 8838 console add new webhook events feat(console, phrases): update the supported webhook events May 13, 2024
@github-actions github-actions bot added the feature Cool stuff label May 13, 2024
@simeng-li simeng-li force-pushed the simeng-log-8836-user-account-interaction-webhooks-support-datahook branch from a9e588a to 6a3bc5e Compare May 14, 2024 06:13
@simeng-li simeng-li force-pushed the simeng-log-8838-console-add-new-webhook-events branch from cd19581 to 1e81276 Compare May 14, 2024 06:14
@simeng-li simeng-li marked this pull request as ready for review May 14, 2024 06:49
Base automatically changed from simeng-log-8836-user-account-interaction-webhooks-support-datahook to master May 15, 2024 03:17
@simeng-li simeng-li force-pushed the simeng-log-8838-console-add-new-webhook-events branch from 0a59a96 to efb41a4 Compare May 15, 2024 03:18
packages/console/src/consts/webhooks.ts Outdated Show resolved Hide resolved
packages/console/src/consts/webhooks.ts Outdated Show resolved Hide resolved
add integration tests for interaction hooks
rename webhook and webhook log keys
fix integration test
add changeset
remove the lint rule disable comment
fix the integration tests
@simeng-li simeng-li force-pushed the simeng-log-8838-console-add-new-webhook-events branch from cb54d71 to 38d300c Compare May 15, 2024 06:04
@simeng-li simeng-li enabled auto-merge (squash) May 15, 2024 06:17
@simeng-li simeng-li merged commit e04d952 into master May 15, 2024
27 checks passed
@simeng-li simeng-li deleted the simeng-log-8838-console-add-new-webhook-events branch May 15, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

3 participants