Feature/advanced log #13
Conversation
|
Hi @mveyrenc and thanks for this PR ! Sorry for being sooooo late to answer 😊 . One question: why do you add a column in the Coding standards: Please stick to the coding standards (same as for eZ Publish) |
|
Hi, We don't use the progession note field because this field is displayed in the course of the import which allows you to see which line is processing. The field that we added is only displayed when the import is completed. More like this is a feature that I added, I preferred not to change the existing one. |
| @@ -454,4 +461,8 @@ public function getScheduledImport() | |||
|
|
|||
| return $scheduledImport; | |||
| } | |||
|
|
|||
| public function getRunningLogMessages() { | |||
There was a problem hiding this comment.
CS: { should be on next line
|
Several things to fix up @mveyrenc , mostly CS. I didn't note everywhere, but it seems that you reformated Moreover, you miss an update file for MySQL and Oracle 😉 |
…ables Fix usage of unknown variables
…QLIImport into feature/advanced_log
| @@ -454,4 +461,9 @@ public function getScheduledImport() | |||
|
|
|||
| return $scheduledImport; | |||
| } | |||
|
|
|||
| public function getRunningLogMessages() | |||
| { | |||
|
@mveyrenc Can you please change your tabs to 4 spaces ? Thanks |
During the process, we store logs in database (sqliimport_item table). When process in over, we display log in the progression notes column of the import list.
Warnings en errors are displayed by default. To display notices, you must click on a link.