Options GUI #6
Options GUI #6
Conversation
|
Wow O_O ! This is what I call a pull request :-). Thanks ! |
|
First remark : Please add the licence header to every new file :) |
| $csvOptions = new SQLICSVOptions( array() ); | ||
|
|
||
| //extract headers in temp file to ensure fast csv parsing | ||
| $f = fopen( $filePath, 'r' ); |
There was a problem hiding this comment.
This method is used to validate file format before storing it on the server. Therefore it must not be cluster aware as it is used on temporary files.
However I'm updating the initialize() method to fetch file from cluster before calling this method.
|
Could you please also add some documentation ? You can make a separate doc file if you wish (markdown format is preferred) |
This reverts commit 28b0774.
|
Alright, I made the changes and redacted the doc. I'm a bit puzzled with markdown syntax though: HTML in code blocks do not appear when viewing file on Github... |
| class SQLIImportInvalidFileFormatException extends SQLIImportBaseException | ||
| { | ||
|
|
||
| } |
There was a problem hiding this comment.
Missing empty line at end of file
|
OK, I think we're good, apart the various notes I left. A rebase is also needed. Good job ! 👍 |
|
Ping @bchoquet-heliopsis Thanks ! |
|
Well I missed your comments from 2 months ago. Longest PR ever, I thought it was dead. |
|
Ping @bchoquet-heliopsis |
|
Sorry but I definitely don't have time to get back to this right now and it's not a priority at all... |
At last, a long time discussed pull request :)
I tried to make it as simple as possible :
ImportOptions[<option name>]whose value will be stored in databaseNB : there is no server side validation for options input but there wasn't either in the textarea version
For complex option input, one can define a YUI3 module to manage his needs and fill in a hidden input field with the computed value. A boilerplate for such a module can be seen in
design/admin/javascript/sqliimportsampleoptionmodule.js.Finally, I added a file option type enabling file upload, validation and storage.
I reckon the code is well commented enough, tell me if you need any more details