Added better mutability, removed some clones #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started using this library in order to modify attributes in my HTML archiver (e.g. modify image src attributes, etc). However I noticed that this library doesn't support mutably querying elements by selectors, so instead of manually implementing it in my code I decided to fork this library instead. Along the way, I modified some other things as well.
Here is the full list of whats changed, off the top of my head:
.into_element
, instead it's.as_element
which returns an option of the borrowed element inside..into_node
for Element for easier conversion, as well as anInto<Node>
just in case.Also, for the doctest in the remove_by function, I added an extra element in that line so that the IDE's auto formatter (not even rustfmt) doesn't strip the extra spaces from that line. VS Code automatically trims the end of each line, which makes that test fail after saving the file.