Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update EOL date #2180

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

docs: update EOL date #2180

wants to merge 1 commit into from

Conversation

dhmlau
Copy link
Member

@dhmlau dhmlau commented Jan 11, 2024

According to the LTS schedule for Node.js https://github.com/nodejs/Release, the EOL date for Node.js 20 is 2026-04-30. So we're updating the EOL date for this module accordingly.

Checklist

  • Sign off your commits with DCO (Developer Certificate of Origin)
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • Commit messages are following our guidelines

@coveralls
Copy link

coveralls commented Jan 11, 2024

Pull Request Test Coverage Report for Build 7507494118

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.818%

Totals Coverage Status
Change from base Build 7493777320: 0.0%
Covered Lines: 7267
Relevant Lines: 8264

💛 - Coveralls

README.md Outdated
@@ -8,7 +8,7 @@ This module adopts the [Module Long Term Support (LTS)](http://github.com/CloudN

| Version | Status | Published | EOL |
| ---------- | --------------- | --------- | -------------------- |
| 4.x | Current | Oct 2018 | Apr 2023 _(minimum)_ |
| 4.x | Current | Oct 2018 | Apr 2026 _(minimum)_ |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But juggler version is already 5.x

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch. I've updated accordingly.

Signed-off-by: dhmlau <dhmlau@ca.ibm.com>
@dhmlau
Copy link
Member Author

dhmlau commented Feb 6, 2024

@samarpanB, I believe I've incorporated your feedback. Could you please review again? Thanks.

@@ -8,7 +8,8 @@ This module adopts the [Module Long Term Support (LTS)](http://github.com/CloudN

| Version | Status | Published | EOL |
| ---------- | --------------- | --------- | -------------------- |
| 4.x | Current | Oct 2018 | Apr 2023 _(minimum)_ |
| 5.x | Current | Sep 2023 | Apr 2026 _(minimum)_ |
| 4.x | Active | Oct 2018 | Apr 2025 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we gonna support 4.x still ?

Copy link
Contributor

@samarpanB samarpanB Feb 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4.x is on nodejs 16

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC, according to the [Module LTS policy], juggler 4.x is still active while Node.js 18 becomes LTS. I believe we need to support it till Apr 2025 where Node.js 18 reaches EOL.
I understand that we seldom make changes to 4.x in reality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants