-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update EOL date #2180
base: master
Are you sure you want to change the base?
docs: update EOL date #2180
Conversation
Pull Request Test Coverage Report for Build 7507494118
💛 - Coveralls |
README.md
Outdated
@@ -8,7 +8,7 @@ This module adopts the [Module Long Term Support (LTS)](http://github.com/CloudN | |||
|
|||
| Version | Status | Published | EOL | | |||
| ---------- | --------------- | --------- | -------------------- | | |||
| 4.x | Current | Oct 2018 | Apr 2023 _(minimum)_ | | |||
| 4.x | Current | Oct 2018 | Apr 2026 _(minimum)_ | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But juggler version is already 5.x
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch. I've updated accordingly.
Signed-off-by: dhmlau <dhmlau@ca.ibm.com>
@samarpanB, I believe I've incorporated your feedback. Could you please review again? Thanks. |
@@ -8,7 +8,8 @@ This module adopts the [Module Long Term Support (LTS)](http://github.com/CloudN | |||
|
|||
| Version | Status | Published | EOL | | |||
| ---------- | --------------- | --------- | -------------------- | | |||
| 4.x | Current | Oct 2018 | Apr 2023 _(minimum)_ | | |||
| 5.x | Current | Sep 2023 | Apr 2026 _(minimum)_ | | |||
| 4.x | Active | Oct 2018 | Apr 2025 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we gonna support 4.x still ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4.x is on nodejs 16
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUC, according to the [Module LTS policy], juggler 4.x is still active while Node.js 18 becomes LTS. I believe we need to support it till Apr 2025 where Node.js 18 reaches EOL.
I understand that we seldom make changes to 4.x in reality.
According to the LTS schedule for Node.js https://github.com/nodejs/Release, the EOL date for Node.js 20 is 2026-04-30. So we're updating the EOL date for this module accordingly.
Checklist
npm test
passes on your machine