chore: replace tslint with eslint rules

.vscode/settings.json

@@ -27,6 +27,15 @@
   "files.insertFinalNewline": true,
   "files.trimTrailingWhitespace": true,
   "tslint.ignoreDefinitionFiles": true,
-  "tslint.nodePath": "./packages/build/node_modules",
-  "typescript.tsdk": "./packages/build/node_modules/typescript/lib"
+  "typescript.tsdk": "./packages/build/node_modules/typescript/lib",
+  "eslint.autoFixOnSave": true,
+  "eslint.run": "onSave",
+  "eslint.nodePath": "./packages/build/node_modules",
+  "eslint.validate": [
+    "javascript",
+    {
+        "language": "typescript",
+        "autoFix": true
+    }
+  ]
 }

.vscode/tasks.json

@@ -34,7 +34,7 @@
       "args": [
         "test"
       ],
-      "problemMatcher": ["$tsc", "$tslint5"]
+      "problemMatcher": ["$tsc", "$eslint-stylish", "$eslint-compact"]
     },
     {
       "label": "Lint all packages",
@@ -47,10 +47,11 @@
         "lint"
       ],
       "problemMatcher": [
-        "$tslint5",
+        "$eslint-stylish",
+        "$eslint-compact",
         {
           // compilation errors - relative paths
-          "owner": "tslint",
+          "owner": "eslint",
           "fileLocation": [
             "relative",
             "${workspaceRoot}"
@@ -66,7 +67,7 @@
         },
         {
           // compilation errors - absolute paths
-          "owner": "tslint",
+          "owner": "eslint",
           "fileLocation": "absolute",
           "severity": "error",
           "pattern": {

benchmark/src/__tests__/benchmark.integration.ts

@@ -3,10 +3,10 @@
 // This file is licensed under the MIT License.
 // License text available at https://opensource.org/licenses/MIT
 
-import {expect} from '@loopback/testlab';
+import { expect } from '@loopback/testlab';
 import * as request from 'request-promise-native';
-import {Benchmark} from '..';
-import {Autocannon, EndpointStats} from '../autocannon';
+import { Benchmark } from '..';
+import { Autocannon, EndpointStats } from '../autocannon';
 
 const debug = require('debug')('test');
 
@@ -17,7 +17,7 @@ const DUMMY_STATS: EndpointStats = {
 
 describe('Benchmark (SLOW)', function() {
   // Unfortunately, the todo app requires one second to start
-  // tslint:disable-next-line:no-invalid-this
+  // eslint-disable-next-line no-invalid-this
   this.timeout(5000);
   it('works', async () => {
     const bench = new Benchmark();
@@ -37,7 +37,7 @@ describe('Benchmark (SLOW)', function() {
     async execute(
       title: string,
       urlPath: string,
-      // tslint:disable-next-line:no-any
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any
       options?: any,
     ): Promise<EndpointStats> {
       if (!options) options = {};

benchmark/src/rest-routing/routing-table.ts

@@ -90,7 +90,7 @@ function givenRouter(router: RestRouter, spec: OpenApiSpec, count: number) {
         // Make it not found
         group = 'groupX';
       }
-      // tslint:disable-next-line:no-any
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any
       const request: any = {
         method: 'get',
         path: `/my/hello/${group}/version_${i}`,

bin/sync-dev-deps.js

@@ -25,19 +25,28 @@ async function syncDevDeps() {
   const buildDeps = require(path.join(rootPath, 'packages/build/package.json'))
     .dependencies;
 
-  const masterDeps = {
-    typescript: buildDeps.typescript,
-    tslint: buildDeps.tslint,
-  };
+  const deps = [
+    'typescript',
+    'eslint',
+    '@typescript-eslint/eslint-plugin',
+    '@typescript-eslint/parser',
+    'eslint-plugin-eslint-plugin',
+  ];
+  const masterDeps = {};
+  for (const d of deps) {
+    masterDeps[d] = buildDeps[d];
+  }
 
-  // Update typescript & tslint dependencies in individual packages
+  // Update typescript & eslint dependencies in individual packages
   for (const pkg of packages) {
     const data = readJsonFile(pkg.manifestLocation);
     let modified = false;
     for (const dep in masterDeps) {
-      if (data.devDependencies && dep in data.devDependencies) {
-        data.devDependencies[dep] = masterDeps[dep];
-        modified = true;
+      if (data.devDependencies && data.devDependencies[dep]) {
+        if (data.devDependencies[dep] !== masterDeps[dep]) {
+          data.devDependencies[dep] = masterDeps[dep];
+          modified = true;
+        }
       }
     }
     if (!modified) continue;

bin/update-greenkeeper-json.js

@@ -87,7 +87,7 @@ if (require.main === module) updateGreenKeeperJson();
 function arraysContainSameElements(actual, expected) {
   return (
     // Same size
-    actual.length == expected.length &&
+    actual.length === expected.length &&
     // `expected` contains all elements of `actual`
     actual.every(e => expected.includes(e)) &&
     // `actual` contains all elements of `expected`

docs/site/OpenAPI-generator.md

@@ -232,7 +232,7 @@ additional model files are generated:
 {% include code-caption.html content="src/models/perform-search-body.model.ts" %}
 
 ```ts
-/* tslint:disable:no-any */
+/* eslint-disable @typescript-eslint/no-explicit-any */
 import {model, property} from '@loopback/repository';
 
 /**

docs/site/Parsing-requests.md

@@ -330,7 +330,7 @@ class FileUploadController {
         else {
           resolve({
             files: request.files,
-            // tslint:disable-next-line:no-any
+            // eslint-disable-next-line @typescript-eslint/no-explicit-any
             fields: (request as any).fields,
           });
         }

docs/site/Testing-your-application.md

@@ -859,7 +859,7 @@ const Dredd = require('dredd');
 
 describe('API (acceptance)', () => {
   let app: HelloWorldApplication;
-  // tslint:disable no-any
+  /* eslint-disable @typescript-eslint/no-explicit-any */
   let dredd: any;
   before(initEnvironment);
   after(async () => {

examples/express-composition/package.json

@@ -57,7 +57,7 @@
   "devDependencies": {
     "@loopback/build": "^1.5.5",
     "@loopback/testlab": "^1.2.10",
-    "@loopback/tslint-config": "^2.0.4",
+    "@loopback/eslint-config": "^1.0.0-1",
     "@types/express": "^4.16.1",
     "@types/node": "^10.11.2",
     "tslint": "^5.16.0",

examples/greeter-extension/package.json

@@ -45,7 +45,7 @@
   "devDependencies": {
     "@loopback/build": "^1.5.5",
     "@loopback/testlab": "^1.2.10",
-    "@loopback/tslint-config": "^2.0.4",
+    "@loopback/eslint-config": "^1.0.0-1",
     "@types/debug": "4.1.4",
     "@types/node": "^10.11.2",
     "tslint": "^5.16.0",

examples/greeter-extension/src/greeting-service.ts

@@ -53,7 +53,7 @@ export class GreetingService {
    * @param name - Name
    */
   async greet(language: string, name: string): Promise<string> {
-    let greeting: string = '';
+    let greeting = '';
 
     const greeter = await this.findGreeter(language);
     if (greeter) {

examples/hello-world/package.json

@@ -14,13 +14,13 @@
     "build:watch": "lb-tsc es2017 --outDir dist --watch",
     "clean": "lb-clean *example-hello-world*.tgz dist package api-docs",
     "verify": "npm pack && tar xf *example-hello-world*.tgz && tree package && npm run clean",
-    "lint": "npm run prettier:check && npm run tslint",
-    "lint:fix": "npm run tslint:fix && npm run prettier:fix",
+    "lint": "npm run prettier:check && npm run eslint",
+    "lint:fix": "npm run eslint:fix && npm run prettier:fix",
     "prettier:cli": "lb-prettier \"**/*.ts\" \"**/*.js\"",
     "prettier:check": "npm run prettier:cli -- -l",
     "prettier:fix": "npm run prettier:cli -- --write",
-    "tslint": "lb-tslint",
-    "tslint:fix": "npm run tslint -- --fix",
+    "eslint": "lb-eslint",
+    "eslint:fix": "npm run eslint -- --fix",
     "pretest": "npm run clean && npm run build",
     "test": "lb-mocha --allow-console-logs \"dist/__tests__/**/*.js\"",
     "posttest": "npm run lint",
@@ -43,10 +43,13 @@
   "devDependencies": {
     "@loopback/build": "^1.5.5",
     "@loopback/testlab": "^1.2.10",
-    "@loopback/tslint-config": "^2.0.4",
+    "@loopback/eslint-config": "^1.0.0-1",
     "@types/node": "^10.11.2",
     "tslint": "^5.16.0",
-    "typescript": "^3.4.5"
+    "typescript": "^3.4.5",
+    "@typescript-eslint/eslint-plugin": "^1.4.2",
+    "@typescript-eslint/parser": "^1.4.2",
+    "eslint-plugin-eslint-plugin": "^2.0.1"
   },
   "keywords": [
     "loopback",