Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add lb3 example application #2803

Merged
merged 1 commit into from May 13, 2019
Merged

feat: add lb3 example application #2803

merged 1 commit into from May 13, 2019

Conversation

nabdelgadir
Copy link
Contributor

@nabdelgadir nabdelgadir commented Apr 26, 2019

Closes #2392.

Implements a new example illustrating how the booter-lb3app package's Lb3AppBooterComponent works for mounting a LoopBack 3 application in a LoopBack 4 project.

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

@nabdelgadir nabdelgadir changed the title feat(examples): add lb3 example application feat: add lb3 example application Apr 30, 2019
@nabdelgadir nabdelgadir force-pushed the lb3-example branch 3 times, most recently from 241ccbc to 47c8184 Compare April 30, 2019 17:18
@nabdelgadir nabdelgadir marked this pull request as ready for review April 30, 2019 17:35
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! The changes look mostly good, I have a couple of important comments regarding test robustness in regards to timing and automigration of LB3 models. The remaining comments are mostly stylistic.

Copy link
Contributor

@b-admike b-admike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall, I've tried out the steps and left some feedback for instructions.

examples/lb3-application/README.md Outdated Show resolved Hide resolved
examples/lb3-application/README.md Show resolved Hide resolved
examples/lb3-application/README.md Outdated Show resolved Hide resolved
examples/lb3-application/README.md Show resolved Hide resolved
examples/lb3-application/README.md Show resolved Hide resolved
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are making great progress 👏

@nabdelgadir nabdelgadir force-pushed the lb3-example branch 2 times, most recently from 61e4f5b to 6c571c3 Compare May 10, 2019 17:43
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please get approval from other reviewers before landing.

examples/lb3-application/package.json Outdated Show resolved Hide resolved
Copy link
Contributor

@b-admike b-admike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

This an example showing how to add an existing LoopBack 3 application to a LoopBack 4 project.

Co-authored-by: Miroslav Bajtoš <mbajtoss@gmail.com>
@nabdelgadir nabdelgadir merged commit bf60011 into master May 13, 2019
@nabdelgadir nabdelgadir deleted the lb3-example branch May 13, 2019 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example: mount LB3 app in LB4
4 participants