feat(eslint-config): enable "no-floating-promises" rule #3219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bajtos
added
the
Internal Tooling
bajtos
force-pushed
the
feat/eslint-rule--no-floating-promise
branch
from
b38c696
to
2d372fe
Compare
bajtos
commented
Jun 24, 2019
| @@ -38,7 +38,7 @@ describe('Sequence', () => { | |||
| let server: RestServer; | |||
| beforeEach(givenAppWithController); | |||
| it('provides a default sequence', async () => { | |||
| whenIRequest() | |||
| await whenIRequest() | |||
There was a problem hiding this comment.
Here is an example of a problem caught by the new rule.
| @@ -63,7 +63,7 @@ describe('Sequence', () => { | |||
| // bind user defined sequence | |||
| server.sequence(MySequence); | |||
|
|
|||
| whenIRequest() | |||
| await whenIRequest() | |||
raymondfeng
approved these changes
Jun 24, 2019
Signed-off-by: Miroslav Bajto拧 <mbajtoss@gmail.com>
Signed-off-by: Miroslav Bajto拧 <mbajtoss@gmail.com>
bajtos
force-pushed
the
feat/eslint-rule--no-floating-promise
branch
from
2d372fe
to
00bcbba
Compare
delete-merged-branch
bot
deleted the
feat/eslint-rule--no-floating-promise
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See typescript-eslint/typescript-eslint#495 that re-implemented the rule in typescript-eslint.
Checklist
馃憠 Read and sign the CLA (Contributor License Agreement) 馃憟
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated馃憠 Check out how to submit a PR 馃憟