Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update build scripts to update package-lock files during release #3847

Merged
merged 1 commit into from Oct 1, 2019

Conversation

raymondfeng
Copy link
Contributor

@raymondfeng raymondfeng commented Sep 30, 2019

Workaround for lerna/lerna#1998

Without this PR, the version property in package-lock.json is not updated to reflect the new version in package.json. As a result, npm i introduces a set of new changes right after the release and such changes artificially make all packages subject to newer versions for the next release.

Checklist

馃憠 Read and sign the CLA (Contributor License Agreement) 馃憟

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

馃憠 Check out how to submit a PR 馃憟

@raymondfeng raymondfeng merged commit 0d2cd88 into master Oct 1, 2019
@raymondfeng raymondfeng deleted the update-package-lock-for-release branch October 1, 2019 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants