Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reduce concurrency to avoid bootstrap issues due to npm locks #3900

Merged
merged 1 commit into from Oct 11, 2019

Conversation

raymondfeng
Copy link
Contributor

@raymondfeng raymondfeng commented Oct 9, 2019

It happens very frequently for me with npm run update-packages, which is also part of our release process.

Sample error:

lerna ERR! npm install exited 254 in '@loopback/service-proxy'
lerna ERR! npm install stderr:
npm ERR! code ENOENT
npm ERR! syscall lchown
npm ERR! path /Users/rfeng/.npm/_locks/staging-1f9c9b6dc2a3f888.lock
npm ERR! errno -2
npm ERR! enoent ENOENT: no such file or directory, lchown '/Users/rfeng/.npm/_locks/staging-1f9c9b6dc2a3f888.lock'
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent

Checklist

馃憠 Read and sign the CLA (Contributor License Agreement) 馃憟

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

馃憠 Check out how to submit a PR 馃憟

It happens very frequently for me with `npm run update-packages`, which
is also part of our release process.

Sample error:

lerna ERR! npm install exited 254 in '@loopback/service-proxy'
lerna ERR! npm install stderr:
npm ERR! code ENOENT
npm ERR! syscall lchown
npm ERR! path /Users/rfeng/.npm/_locks/staging-1f9c9b6dc2a3f888.lock
npm ERR! errno -2
npm ERR! enoent ENOENT: no such file or directory, lchown '/Users/rfeng/.npm/_locks/staging-1f9c9b6dc2a3f888.lock'
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent
@emonddr
Copy link
Contributor

emonddr commented Oct 9, 2019

Some folks, 2 years ago, would set concurrency to 1 : lerna/lerna#789 .

@raymondfeng
Copy link
Contributor Author

raymondfeng commented Oct 10, 2019

lerna@3.17.0 might have fixed/shadowed the issue - maybe due to lerna/lerna#2224.

Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@raymondfeng
Copy link
Contributor Author

Close it as lerna@3.17.0 seems to have removed the issue.

@raymondfeng
Copy link
Contributor Author

Hmm, the problem comes back again.

@raymondfeng raymondfeng reopened this Oct 11, 2019
@raymondfeng raymondfeng merged commit 221373e into master Oct 11, 2019
@raymondfeng raymondfeng deleted the fix-lerna-bootstrap branch October 11, 2019 03:35
@emonddr
Copy link
Contributor

emonddr commented Oct 11, 2019

@raymondfeng . See my comment above. Perhaps try concurrency set to 1. Just as a test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants