Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dist files from top-level tsconfig to speed up eslint checks 馃弾馃殌 #4707

Merged
merged 1 commit into from
Feb 24, 2020
Merged

Remove dist files from top-level tsconfig to speed up eslint checks 馃弾馃殌 #4707

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
"examples/*/node_modules/**",
"packages/*/node_modules/**",
"extensions/*/node_modules/**",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"extensions/*/node_modules/**",
"**/node_modules/**",

BTW, any idea why this is not **/node_modules/**, ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IDK, to be honest. I was thinking about simplifying the pattern too, but then decided to keep my changes minimal to get them landed faster.

Would you like to open a follow-up pull request to simplify this part of exclude configuration?

"**/dist/**",
"**/*.d.ts"
]
}