Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update node_modules exclude in root tsconfig #4727

Merged
merged 1 commit into from
Feb 24, 2020
Merged

chore: update node_modules exclude in root tsconfig #4727

merged 1 commit into from
Feb 24, 2020

Conversation

dougal83
Copy link
Contributor

#4707 (comment)

Signed-off-by: Douglas McConnachie dougal83+git@gmail.com

See also #4707

Checklist

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

@dougal83
chore: update node_modules exclude in root tsconfig
2e46405 
loopbackio#4707 (comment)

Signed-off-by: Douglas McConnachie <dougal83+git@gmail.com>
bajtos
bajtos approved these changes Feb 24, 2020
View reviewed changes
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @dougal83 for the pull request! ❤️

The changes LGTM, I'll trust you that you have checked this new config and verified that it works.

Let's wait a bit before landing, to give other maintainers a chance to react.

@bajtos bajtos added community-contribution Internal Tooling Issues related to our tooling and monorepo infrastructore labels Feb 24, 2020
@dougal83
Copy link
Contributor Author

The changes LGTM, I'll trust you that you have checked this new config and verified that it works.

FYI - I've run the tests and fired up a sandbox app.

@raymondfeng raymondfeng merged commit f390f27 into loopbackio:master Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raymondfeng raymondfeng raymondfeng approved these changes

@bajtos bajtos bajtos approved these changes

Assignees
No one assigned
Labels
Internal Tooling Issues related to our tooling and monorepo infrastructore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dougal83 @raymondfeng @bajtos