fix(cli): update tsconfig template excludes #4728
Conversation
There was a problem hiding this comment.
Thank you @dougal83 for following up on my PR improving eslint config 👍
The code changes LGTM.
However, the commit message is not very good. AFAIK, chore commits are not mentioned in release notes that are auto-generated by conventional-commit tooling. I'd like to have this change mentioned in the release notes, because it's affecting experience of @loopback/cli users. Both feat and fix is fine with me.
bajtos
added
community-contribution
Internal Tooling
loopbackio#4707 (comment) Signed-off-by: Douglas McConnachie <dougal83+git@gmail.com>
dougal83
force-pushed
the
chore/update-cli-template-root-tsconfig
branch
from
bfa8048
to
048fda9
Compare
|
@bajtos Updated: Thanks for the feedback. 👍 I was not aware how the commit messages affected the process down the line. |
dougal83
changed the title
| @@ -31,8 +31,8 @@ | |||
| }, | |||
| "include": ["src"], | |||
| "exclude": [ | |||
| "node_modules/**", | |||
| "packages/*/node_modules/**", | |||
| "**/node_modules/**", | |||
There was a problem hiding this comment.
I think here it should still be "/node_modules/**", since the loopback app has node_modules as the root level folder.
Otherwise LGTM.
There was a problem hiding this comment.
Please check this glob example and let me know if it is correct.
|
@raymondfeng Would the change to dist here be surplus to requirements? |
#4707 (comment)
Signed-off-by: Douglas McConnachie dougal83+git@gmail.com
See also #4707
Checklist
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated