[DO NOT MERGE] rework eslint config to use proper TS projects #5590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable `createDefaultProgram` option and ensure every linted file belongs to some `tsconfig`. Signed-off-by: Miroslav Bajto拧 <mbajtoss@gmail.com>
bajtos
added
the
Internal Tooling
bajtos
commented
May 28, 2020
| "packages/repository/examples/**/*.ts", | ||
| "packages/tsdocs/bin/*.js", | ||
| "packages/tsdocs/fixtures/**/*.js" | ||
| ], |
There was a problem hiding this comment.
Discussion point: instead of adding all of those files to the dummy tsconfig for eslint only, should we add them to "real" typescript projects and run them through the compiler to get basic type checks?
bajtos
commented
May 28, 2020
| @@ -5,3 +5,4 @@ coverage/ | |||
| **/*.d.ts | |||
| /docs/_preview | |||
| /docs/_loopback.io | |||
| **/.eslintrc.js | |||
There was a problem hiding this comment.
This is a bad idea. We are running Prettier as part of eslint, this line disables prettier formatting checks for .eslintrc files.
This was referenced Jul 21, 2020
|
I think #5983 is good enough for now, we can revisit the status once typescript-eslint/typescript-eslint#1192 and/or typescript-eslint/typescript-eslint#2094 is resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable
createDefaultProgramoption and ensure every linted file belongs to sometsconfig, see https://github.com/typescript-eslint/typescript-eslint/blob/master/docs/getting-started/linting/MONOREPO.md#getting-started---monorepo-configurationUnfortunately, eslint is sometimes running out of memory with this new setup. I think we have to wait until typescript-eslint/typescript-eslint#1192 and/or typescript-eslint/typescript-eslint#2094 is resolved by typescript-eslint.
The pull request contains a single "all-in-one" commit right now, we will need to split it into multiple smaller commits before landing. I think the change in eslint-config is breaking backwards compatibility and needs to be described as such.
Migration guide for LB users:
Checklist
馃憠 Read and sign the CLA (Contributor License Agreement) 馃憟
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated馃憠 Check out how to submit a PR 馃憟