Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use NPM Workspaces [NOT MERGE] #7082

Closed
wants to merge 2 commits into from
Closed

Use NPM Workspaces [NOT MERGE] #7082

wants to merge 2 commits into from

Conversation

frbuceta
Copy link
Contributor

@frbuceta frbuceta commented Feb 4, 2021 •
edited

Now that NPM v7 is officially stable I want to start testing to incorporate it into the Loopback 4 monorepo

Problem list

Checklist

  • DCO (Developer Certificate of Origin) signed in all commits
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

馃憠 Check out how to submit a PR 馃憟

@frbuceta frbuceta self-assigned this Feb 4, 2021
@frbuceta frbuceta changed the title Use NPM Workspaces Use NPM Workspaces [NOT MERGE] Feb 4, 2021
@frbuceta frbuceta force-pushed the use-npm-workspaces branch 3 times, most recently from c4f472d to 97e7e8b Compare February 8, 2021 21:47
@frbuceta frbuceta force-pushed the use-npm-workspaces branch 6 times, most recently from 435508a to e439aab Compare February 14, 2021 11:41
@frbuceta
chore: use npm 7 workspaces
adad8d4 
Signed-off-by: Francisco Buceta <frbuceta@gmail.com>
@frbuceta
chore: disable yarn test
af59e6f 
Signed-off-by: Francisco Buceta <frbuceta@gmail.com>
@frbuceta frbuceta force-pushed the use-npm-workspaces branch 2 times, most recently from 038c292 to af59e6f Compare February 14, 2021 13:01
@frbuceta frbuceta mentioned this pull request Feb 17, 2021
Merged
2 tasks
@frbuceta frbuceta closed this Feb 24, 2021
@frbuceta frbuceta deleted the use-npm-workspaces branch April 9, 2021 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achrinza achrinza Awaiting requested review from achrinza achrinza is a code owner

@agnes512 agnes512 Awaiting requested review from agnes512

@bajtos bajtos Awaiting requested review from bajtos

@dhmlau dhmlau Awaiting requested review from dhmlau dhmlau is a code owner

@dougal83 dougal83 Awaiting requested review from dougal83

@emonddr emonddr Awaiting requested review from emonddr

@hacksparrow hacksparrow Awaiting requested review from hacksparrow

@jannyHou jannyHou Awaiting requested review from jannyHou

@madaky madaky Awaiting requested review from madaky

@marioestradarosa marioestradarosa Awaiting requested review from marioestradarosa marioestradarosa is a code owner

@mschnee mschnee Awaiting requested review from mschnee mschnee is a code owner

@nabdelgadir nabdelgadir Awaiting requested review from nabdelgadir nabdelgadir is a code owner

@nflaig nflaig Awaiting requested review from nflaig nflaig is a code owner

@raymondfeng raymondfeng Awaiting requested review from raymondfeng raymondfeng is a code owner

Assignees

@frbuceta frbuceta

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@frbuceta