Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove dist files from root tsconfig + update node_modules pattern #566

Merged

Conversation

dougal83
Copy link
Contributor

This speeds up npm run eslint, good practice

see loopbackio/loopback-next#4707

Signed-off-by: Douglas McConnachie dougal83+git@gmail.com

@dougal83 dougal83 changed the title chore: remove dist files from rot tsconfig chore: remove dist files from root tsconfig Feb 22, 2020
This speeds up `npm run eslint`, good practice

see loopbackio/loopback-next#4707

Signed-off-by: Douglas McConnachie <dougal83+git@gmail.com>
loopbackio/loopback-next#4707 (comment)

Signed-off-by: Douglas McConnachie <dougal83+git@gmail.com>
@dougal83 dougal83 changed the title chore: remove dist files from root tsconfig chore: remove dist files from root tsconfig + update node_modules pattern Feb 24, 2020
Copy link
Contributor

@jannyHou jannyHou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@hacksparrow hacksparrow merged commit 994a8f9 into loopbackio:master Feb 24, 2020
@raymondfeng
Copy link
Contributor

We should run the following commands to understand the impact:

  1. rm .eslintcache
  2. npm run eslint -- --debug
  3. open .eslintcache to see what files are linted
  4. change some TS files
  5. npm run eslint --debug to see how the cache is leveraged to speed up eslint

@raymondfeng
Copy link
Contributor

Some observations:

Before I pull in this commit, dist does not seem to be linted or cached by eslint:

  1. The .eslintcache file does not have any entries from dist/**/*.ts
  2. npm run eslint -- --debug does not show any mentioning of dist

@dougal83
Copy link
Contributor Author

Some observations:

Before I pull in this commit, dist does not seem to be linted or cached by eslint:

  1. The .eslintcache file does not have any entries from dist/**/*.ts
  2. npm run eslint -- --debug does not show any mentioning of dist

Fair enough, it was unnecessary in that case. TBH I didn't look deeper than comparing time npm run eslint results. Thank you for checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants