fix: Reduce amount of local variables thanks to PHPStan fix.

This issue will be fixed in PHPStan > 1.8.1. See phpstan/phpstan-src#1519 for more info.
loophp · Jul 18, 2022 · 4ad921f · 4ad921f
1 parent 95da1a1
commit 4ad921f
Show file tree

Hide file tree

Showing 5 changed files with 1 addition and 21 deletions.
diff --git a/.gitattributes b/.gitattributes
@@ -17,8 +17,6 @@ infection.json export-ignore
 LICENSE export-ignore
 Makefile export-ignore
 phpbench.json export-ignore
-phpstan.neon.dist export-ignore
 phpunit.xml export-ignore
-psalm-baseline.xml export-ignore
 psalm.xml export-ignore
 README.md export-ignore
diff --git a/phpstan.neon.dist b/phpstan.neon.dist
diff --git a/psalm-baseline.xml b/psalm-baseline.xml
diff --git a/psalm.xml b/psalm.xml
@@ -3,7 +3,6 @@
     xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
     xmlns="https://getpsalm.org/schema/config"
     xsi:schemaLocation="https://getpsalm.org/schema/config vendor/vimeo/psalm/config.xsd"
-    errorBaseline="psalm-baseline.xml"
 >
     <projectFiles>
         <directory name="./src" />

diff --git a/src/CachingIteratorAggregate.php b/src/CachingIteratorAggregate.php
@@ -48,10 +48,7 @@ public function __construct(Iterator $iterator)
      */
     public function getIterator(): Generator
     {
-        /** @var array<int, array{0:TKey, 1:T}> $cache */
-        $cache = $this->iterator->getCache();
-
-        foreach ($cache as [$key, $current]) {
+        foreach ($this->iterator->getCache() as [$key, $current]) {
             yield $key => $current;
         }