Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Ruby 3.0 the min version #1544

Merged
merged 6 commits into from Dec 28, 2023
Merged

Make Ruby 3.0 the min version #1544

merged 6 commits into from Dec 28, 2023

Conversation

iMacTia
Copy link
Member

@iMacTia iMacTia commented Dec 27, 2023

Description

Make Ruby 3.0 the min version.
Fixes #1543

@iMacTia iMacTia self-assigned this Dec 27, 2023
AlexWayfer
AlexWayfer reviewed Dec 27, 2023
View reviewed changes
Copy link
Contributor

@AlexWayfer AlexWayfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

.github/workflows/refresh_team_page.yml Outdated Show resolved Hide resolved
.rubocop_todo.yml
@@ -1,6 +1,6 @@
# This configuration was generated by
# `rubocop --auto-gen-config`
# on 2022-08-08 14:26:32 UTC using RuboCop version 1.33.0.
# on 2023-12-27 11:12:52 UTC using RuboCop version 1.59.0.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems not completely relevant, but, I guess, acceptable.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Timestamp maybe not, I agree, but the RuboCop version can be useful 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'm generally talking more about RuboCop itself… the PR is about minimal Ruby version, and there are RuboCop updates. But it's up to you, I'm not against it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah right, good point. I've limited changes to those necessary after increasing the TargetRubyVersion rubocop config from 2.6 to 3.0. This change was required because Rubocop needs that to be the same as the Gemspec's required_ruby_version. After that some new offences popped up

README.md Show resolved Hide resolved
spec/spec_helper.rb Show resolved Hide resolved
@olleolleolle
Copy link
Member

This good thing means that endless methods are available!

olleolleolle
olleolleolle approved these changes Dec 28, 2023
View reviewed changes
Copy link
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super!

@olleolleolle olleolleolle merged commit 074506e into main Dec 28, 2023
7 checks passed
@olleolleolle olleolleolle deleted the mg/ruby-30-min-version branch December 28, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWayfer AlexWayfer AlexWayfer left review comments

@olleolleolle olleolleolle olleolleolle approved these changes

Assignees

@iMacTia iMacTia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iMacTia @olleolleolle @AlexWayfer