chore: add support for upcoming 0.73 (#1038)

* chore: add support for upcoming 0.73 reference: react-native-community/discussions-and-proposals#671 * chore: revert xml def * fix: backward compatiblity for AGP namespace
lottie-react-native · Jul 21, 2023 · 4579e5f · 4579e5f
1 parent 076de43
commit 4579e5f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/packages/core/android/build.gradle b/packages/core/android/build.gradle
@@ -33,6 +33,12 @@ if (isNewArchitectureEnabled()) {
 }
 
 android {
+    def agpVersion = com.android.Version.ANDROID_GRADLE_PLUGIN_VERSION
+    // Check AGP version for backward compatibility reasons
+    if (agpVersion.tokenize('.')[0].toInteger() >= 7) {
+        namespace = "com.airbnb.android.react.lottie"
+    }
+
     compileSdk getExtOrDefault('compileSdkVersion', 31)
 
     // Used to override the NDK path/version on internal CI or by allowing

diff --git a/packages/core/android/src/main/AndroidManifest.xml b/packages/core/android/src/main/AndroidManifest.xml
@@ -1,6 +1,3 @@
-<?xml version="1.0" encoding="utf-8"?>
-<manifest package="com.airbnb.android.react.lottie"
-          xmlns:android="http://schemas.android.com/apk/res/android">
-
-  <uses-permission android:name="android.permission.INTERNET"/>
-</manifest>
+<manifest xmlns:android="http://schemas.android.com/apk/res/android"
+    package="com.airbnb.android.react.lottie">
+</manifest>