Fix iOS frames being calculated incorrectly #1019
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of RC4 (This PR), Lottie no longer wraps the Native component in a separate view, and passes all the view props to the native implementation. This causes an issue with Lottie on iOS, as the iOS version of Lottie is made of two different views:
RCTView
from react native that gets all of the props (Like background color, etc)LottieAnimationView
which is aSubview
of theRCTView
The
LottieAnimationView
is tapping into theRCTView
'sframe
and giving it to itself. But this is incorrect as theframe
property on iOS has the coordinates of theRCTView
as well, leading to a rather gnarly offset. Instead offrame
, thebounds
property should be used.This PR does three things:
LottieAnimationView
fromframe
tobounds
and removes the hacky override at the top.NOTE: The reason wrapping the Native component with a view fixed the issue is that the
frame
of theRCTView
would be equal to thebounds
, due to the styling being applied to the parent and the fact thatframe
is calculated relative to the parent