Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: react native macos build #1031

Merged
merged 1 commit into from Jun 22, 2023
Merged

fix: react native macos build #1031

merged 1 commit into from Jun 22, 2023

Conversation

matinzd
Copy link
Collaborator

@matinzd matinzd commented May 25, 2023

Fixes: #1018

@matinzd
Copy link
Collaborator Author

matinzd commented May 25, 2023

/cc @Saadnajmi

@matinzd matinzd requested a review from emilioicai May 25, 2023 12:57
@Saadnajmi
Copy link

/cc @Saadnajmi

Do we have a way to test macOS? What we've done in other repos is move the test app to use this (https://github.com/microsoft/react-native-test-app). That way, it is easy to add out of tree platforms like macOS and windows without needing to worry about maintaining extra boilerplate code.

@matinzd
Copy link
Collaborator Author

matinzd commented May 25, 2023

/cc @Saadnajmi

Do we have a way to test macOS? What we've done in other repos is move the test app to use this (https://github.com/microsoft/react-native-test-app). That way, it is easy to add out of tree platforms like macOS and windows without needing to worry about maintaining extra boilerplate code.

Yeah, this is what I was trying to go for but we somehow decided to not go with it at that time.
Maybe it's a good time to move to RNTA.

@matinzd matinzd force-pushed the fix/react_native_macos_build branch from 56c092e to 48fb896 Compare June 22, 2023 16:23
@matinzd matinzd merged commit 3c74016 into master Jun 22, 2023
@matinzd matinzd deleted the fix/react_native_macos_build branch June 22, 2023 16:29
@Saadnajmi
Copy link

Awesome! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build crashing on React native macos
3 participants