New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better description for Shrink Database button #4508
base: 1.23.X
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing the meaning of a translation is not great, as this leaves the translators unaware of this change.
A better approach would be to introduce a translation string and remove the current one.
This also allows using the i18n-t
-component to display VACUUM
/AUTO_VACUUM
as <code>VACUUM</code>
/<code>AUTO_VACUUM</code>
Here is the relevant line:
<div class="form-text mt-2 mb-4 ms-2">{{ $t("shrinkDatabaseDescription") }}</div> |
I translated via Weblate and I bet that I translated few already translated i18n keys with changed English source. But I like to have HTML's |
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There may be other merge conflicts that come up. v2.0 does support mariadb next to sqlite, but said db still needs to be integrated here as well |
This PR is for 1.23.x only |
Since merging conflicts on Weblate is painful, as the git repo is read only. And removing the key is likely causing this problem. I think we need to find another way to "deprecated" this key instead of removing it. |
I think this should not cause a merge-conflict if merged directly after #4436 What might indeed be problematic is that users can't supply translations for |
Since it is for the 1.23.X branch, it will happen when I merge the 1.23.x branch to master, I believe. Of course I can merge the 1.23.X branch to master after #4436, but it is kind of "soft-locked".
You are right. And 1.23.X is indeed not translatable in the current stage, as Weblate don't support for multiple branches. (Or I don't know how to set up) For simplicity, I would suggest this pr should be merged into the master branch directly and also be merged after #4436. |
@louislam: |
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
As discussed in #2470 (comment)
Previous description suggested that you need to recreate your database from scratch.
Type of change
Please delete any options that are not relevant.
Checklist