New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use template_card
instead of text
messages for the WeCom notification provider
#4516
base: master
Are you sure you want to change the base?
Conversation
Maybe the English version is outdated. It's documented in this Chinese one: |
This comment was marked as resolved.
This comment was marked as resolved.
Another thing that I forgot in the second review (not adding this would also be fine ^^). |
The reason for this arrangement is that this way a quick status will show up in brief view. Other wise you have to click into that message to see the status. Or we can just discard that most up title. |
There's already a builtin call-to-action function, you click the message it will jump to the monitor url. I just did not find a quick way to get the site url. |
template_card
instead of text
messages for the WeCom notification provider
I think it looks better without the title bar. Push the change. |
|
@CommanderStorm |
I think that handling is wrong. Going by the docs, that should work. |
I actually agree with you, but as I said, card_action is mandatory for template_card, and URL is mandatory for card_action. I personally think that's pretty stupid, but that's the way of one of the largest tech companies around here. |
Co-authored-by: Frank Elsinga <frank@elsinga.de>
I just went over the discussion to look if there is something left open and two things are currently blocking a merge:
|
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
add markdown message support for WeCom notification provider
Type of change
Checklist
Screenshots (if any)
UP
DOWN