Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add toggle to hide the uptime percentage on a statuspage #4587

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

broodroosterdev
Copy link

@broodroosterdev broodroosterdev commented Mar 15, 2024

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

This PR adds a new 'Hide Uptime Percentage' setting to the status page.

Fixes #3774

Type of change

Please delete any options that are not relevant.

  • User interface (UI)
  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

image
image

Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.

@louislam

@broodroosterdev broodroosterdev changed the title Add toggle to hide the uptime percentage on a statuspage Feat: Add toggle to hide the uptime percentage on a statuspage Mar 19, 2024
@broodroosterdev broodroosterdev marked this pull request as ready for review March 21, 2024 20:14
Copy link
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all other toggles "show" something
=> please change this toggle to "show only last heartbeat" (or other naming) (default=false) as well.

src/components/PublicGroupList.vue Outdated Show resolved Hide resolved
@CommanderStorm CommanderStorm marked this pull request as draft March 27, 2024 17:36
@CommanderStorm CommanderStorm added the area:status-page Everything related to the status page label Apr 3, 2024
broodroosterdev and others added 2 commits April 12, 2024 15:12
Co-authored-by: Frank Elsinga <frank@elsinga.de>
@broodroosterdev
Copy link
Author

all other toggles "show" something => please change this toggle to "show only last heartbeat" (or other naming) (default=false) as well.

Thank you for taking the time to review this PR.
Great suggestion, I have changed the code to "Show Last Heartbeat Only", and renamed all the internal variables as well.

Are there any other changes needed for this to be merged?

@CommanderStorm CommanderStorm added the needs:review this PR needs a review by maintainers or other community members label May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:status-page Everything related to the status page needs:review this PR needs a review by maintainers or other community members
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide service percentage on status page
2 participants