New issue

Jump to bottom

Do not ignore Union argument ordering in tests #248

Merged

lovasoa merged 4 commits into lovasoa:master from dairiki:bug.union-ordering

Sep 17, 2023

+29 −11

Collaborator

dairiki commented Sep 16, 2023 •

edited

Loading

The union argument ordering is important!

What's here:

Revert b61cd50. That commit effectively hides failing tests by ignoring the argument order of union fields.
The one test that fails because of that reversion is marked an expected failure.
A new version of that failing test is added. The new version does ignore the union argument ordering (and so is expected to pass).

Related

The failing test fails due to #247.

This was discussed in PR #246.

dairiki added 3 commits

September 16, 2023 15:50


          Revert "Ignore union ordering"

3a36936

This reverts commit b61cd50.


          test: mark expected failure, add separate test of its non-failing bits

eb12c18


          ci(tests): report skipped/xfailed tests

dairiki marked this pull request as ready for review

September 16, 2023 23:49

dairiki requested a review from lovasoa

September 16, 2023 23:50

lovasoa reviewed

View reviewed changes

tests/test_field_for_schema.py Show resolved Hide resolved


          docs(test): add link for context

ed29858

Co-authored-by: Ophir LOJKINE <contact@ophir.dev>

lovasoa merged commit f315d71 into lovasoa:master

dairiki deleted the bug.union-ordering branch

September 17, 2023 02:57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet