Skip to content

Commit

Permalink
Automated rollback of commit 9b420b5.
Browse files Browse the repository at this point in the history
*** Reason for rollback ***

Incompatible pipeline still showing failures: https://buildkite.com/bazel/bazelisk-plus-incompatible-flags/builds/1320

Need to investigate why some fixes @Head seem not to work.

*** Original change description ***

Roll forward bazelbuild@1fdc628: default --incompatible_config_setting_private_default_visibility to true

This was rolled back in bazelbuild@d4fc6db
due to failing Bazel downstream tests. I fixed as many as I was aware of: see latest comments on bazelbuild#12933.

Fixes bazelbuild#12933.

PiperOrigin-RevId: 485901094
Change-Id: Ifed7424c482d4feda76811838209e3e10607471b
  • Loading branch information
gregestren authored and Lucas Ripoche committed Jun 13, 2023
1 parent 33450a7 commit 1aadacf
Showing 1 changed file with 1 addition and 3 deletions.
Expand Up @@ -136,9 +136,7 @@ public ParallelismConverter() throws OptionsParsingException {

@Option(
name = "incompatible_config_setting_private_default_visibility",
// TODO(b/179944632): remove this flag when all repos work with this=true +
// --incompatible_enforce_config_setting_visibility=true.
defaultValue = "true",
defaultValue = "false",
documentationCategory = OptionDocumentationCategory.STARLARK_SEMANTICS,
effectTags = {OptionEffectTag.LOADING_AND_ANALYSIS},
metadataTags = {OptionMetadataTag.INCOMPATIBLE_CHANGE},
Expand Down

0 comments on commit 1aadacf

Please sign in to comment.